Remove settings only on app uninstall #6024
Conversation
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rablador)
ios/MullvadVPN/AppDelegate.swift line 507 at r1 (raw file):
self.accessMethodRepository.reloadWithDefaultsAfterDataRemoval() try? self.relayCacheTracker.refreshCachedRelays()
Why do we force a cache read here ? Or rather, what behaviour did we observe after removing settings that led to writing this line ?
buggmagnet
force-pushed
the
remove-settings-only-on-app-uninstall-ios-577
branch
2 times, most recently
from
4dccd01 to
efa37d6
Compare
buggmagnet
force-pushed
the
remove-settings-only-on-app-uninstall-ios-577
branch
from
efa37d6 to
11a2609
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rablador)
ios/MullvadVPN/AppDelegate.swift line 507 at r1 (raw file):
Previously, buggmagnet wrote…
Why do we force a cache read here ? Or rather, what behaviour did we observe after removing settings that led to writing this line ?
This was discussed offline
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rablador)
We should not remove any settings when a user logs out or explicitly deletes an account. Or rather, only app uninstall should trigger a removal of app settings.
This change is